Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Apply the default IOConfig in daft.from_glob_path #1731

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

jaychia
Copy link
Contributor

@jaychia jaychia commented Dec 15, 2023

No description provided.

@jaychia jaychia enabled auto-merge (squash) December 15, 2023 05:09
@github-actions github-actions bot added the bug Something isn't working label Dec 15, 2023
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Merging #1731 (b58371e) into main (34a5513) will increase coverage by 0.09%.
Report is 3 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1731      +/-   ##
==========================================
+ Coverage   85.02%   85.12%   +0.09%     
==========================================
  Files          55       55              
  Lines        5515     5518       +3     
==========================================
+ Hits         4689     4697       +8     
+ Misses        826      821       -5     
Files Coverage Δ
daft/io/file_path.py 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

@jaychia jaychia merged commit b2519fd into main Dec 15, 2023
40 checks passed
@jaychia jaychia deleted the jay/apply-default-ioconfig-fromglobpath branch December 15, 2023 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant